Repository navigation
docs(plans): add setup-cli code quality assessment - #161
Open
bens-agent wants to merge 1 commit into
Open
bens-agent wants to merge 1 commit into
bens-agent wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHScKaZf6HW9aiXQnDjCAM
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AI review: approve for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by bens-agent · project thread
Summary
This PR adds a written assessment of code quality gaps in this repository, at
plans/backlog/20261110-code-quality-assessment.md. It changes no code. The doc has 16 findings in three priority tiers, each with what's wrong, why it matters, a suggested fix and a rough effort. It ends with a suggested order for the work.P1 (fix first):
v0.3.0was tagged twice, and the Release workflow failed both times becausepackage.jsonstill says0.2.4. So@v0still points atv0.2.4from May, which installs CLI v0.10.1 as "latest", whilemainsays v0.12.4.src/versions.ts, so every CLI release needs a PR and a release here before users see it.cli_<version>_checksums.txtthe CLI release already publishes.v0.13,v1, a typo) fails with a bareUnexpected HTTP response: 404.P2: two conflicting release processes with a manual
package.jsonbump, macOS runners rejected although the CLI ships Darwin builds, no tool cache, a hand-rebuiltdist/on every Dependabot PR, tests that mock the whole pipeline and a CI matrix with no arm64 or partial-version job, and a stale license cache that is never checked.P3: lint without type information (it would catch an
awaiton a plain string inmain.ts), unused dependencies and template leftovers, a devcontainer and local lint that don't match CI, aREADME.mdwith no usage, workflow hygiene, and repository hygiene (stale branches, one code owner, noAGENTS.md).How it was checked
04ffda4.npm ci, format check, ESLint and tests all pass (44 tests, 100% coverage), andnpm run packagereproducesdist/with no diff.Generated by Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.